feat: add position parameter to gg_add_stats for error bar adjustments

[martincadek]

What changes are proposed in this pull request?

Bug Fixes

• Fixed a bug in gg_lineplot() where error bars remained fixed to the center (position_identity()) while points and lines were correctly shifted via position adjustments. The internal gg_add_stats() function now accepts a position argument to properly pass position adjustments downstream (closes Add position argument to gg_add_stats internal function #275, @martincadek).

---

Pre-review Checklist (if item does not apply, mark is as complete)

• All GitHub Action workflows pass with a ✅
• PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
• If a bug was fixed, a unit test was added.
• Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
• Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

• If a bug was fixed, a unit test was added.
• Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
• Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

• Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
• All GitHub Action workflows pass with a ✅
• Approve Pull Request
• Merge the PR. Please use "Squash and merge" or "Rebase and merge".

[github-actions]

✅ All contributors have signed the CLA
_{Posted by the CLA Assistant Lite bot.}

[github-actions]

Unit Tests Summary

  1 files  256 suites   3m 34s ⏱️
256 tests 256 ✅ 0 💤 0 ❌
747 runs  747 ✅ 0 💤 0 ❌

Results for commit c1ae490.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
add_hierarchical_count_row	💚	$1.43$	$-1.01$	add_hierarchical_count_row_works
adjust_stat_columns_wrap	💔	$0.66$	$+1.10$	adjust_stat_columns_wrap_validates_input_correctly
annotate_gg	💚	$5.31$	$-1.03$	annotate_lineplot_df_warns_if_plot_is_not_generated_by_gg_lineplot
annotate_gg_pkc	💔	$0.89$	$+1.72$	annotate_pkc_df_warns_when_given_a_standard_ggplot_object
gg_pkc_lineplot	💔	$0.25$	$+1.06$	gg_pkc_lineplot_catches_invalid_combinations_and_missing_inputs
tbl_baseline_chg	💔	$31.00$	$+2.00$	tbl_baseline_chg_works
tbl_hierarchical_incidence_rate	💔	$4.31$	$+3.20$	tbl_hierarchical_incidence_rate_runs_with_minimum_arguments
tbl_hierarchical_rate_by_grade	💔	$3.41$	$+19.55$	tbl_hierarchical_rate_by_grade_works
tbl_rmpt	💔	$15.65$	$+1.53$	tbl_rmpt_works_with_default_parameters_Example_1_
tbl_roche_subgroups	💚	$23.60$	$-21.42$	tbl_roche_subgroups_time_to_event_NULL_works
tbl_roche_summary	💔	$3.47$	$+1.43$	tbl_roche_summary_works

Results for commit f7e4c57

♻️ This comment has been updated with latest results.

[github-actions]

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------
R/add_blank_rows.R                          63       0  100.00%
R/add_difference_row.R                     101       0  100.00%
R/add_forest_utils.R                        97      10  89.69%   76-79, 94-100
R/add_forest.R                             139       0  100.00%
R/add_hierarchical_count_row.R              33       0  100.00%
R/adjust_stat_columns_wrap.R                29       1  96.55%   59
R/annotate_gg_km.R                         135       0  100.00%
R/annotate_gg_pkc.R                         92       0  100.00%
R/annotate_gg.R                             81       0  100.00%
R/ard_tabulate_abnormal_by_baseline.R       65       0  100.00%
R/crane-package.R                            2       2  0.00%    26-27
R/deprecated.R                              21      21  0.00%    18-54
R/df_add_poolings.R                         41       0  100.00%
R/get_cox_pairwise_df.R                    163       0  100.00%
R/gg_km_utils.R                             35      14  60.00%   20-37
R/gg_km.R                                  143      37  74.13%   55-58, 75, 102, 176-181, 184-187, 197-199, 204-205, 239-241, 248-251, 255, 266-270, 283, 285-287
R/gg_lineplot.R                             94       0  100.00%
R/gg_mmrm_lineplot.R                       102       1  99.02%   106
R/gg_pkc_lineplot.R                         98       0  100.00%
R/gg_utils.R                               222       0  100.00%
R/label_roche.R                             72       0  100.00%
R/modify_header_rm_md.R                     18       2  88.89%   35-36
R/modify_zero_recode.R                      20       1  95.00%   64
R/reverse_difference_ci.R                   33       0  100.00%
R/tbl_baseline_chg.R                       188       0  100.00%
R/tbl_coxph.R                               90       1  98.89%   229
R/tbl_hierarchical_incidence_rate.R        291       4  98.63%   430-433
R/tbl_hierarchical_rate_and_count.R        339      13  96.17%   343, 425, 446-456
R/tbl_hierarchical_rate_by_grade.R         317       3  99.05%   169-171
R/tbl_listing.R                             35       0  100.00%
R/tbl_mmrm.R                               254       1  99.61%   393
R/tbl_null_report.R                          9       0  100.00%
R/tbl_rmpt.R                               157      12  92.36%   299-304, 316-321
R/tbl_roche_subgroups.R                    155       0  100.00%
R/tbl_roche_summary.R                       64       0  100.00%
R/tbl_shift.R                              116       0  100.00%
R/tbl_survfit_quantiles.R                  154       0  100.00%
R/tbl_survfit_times.R                       92       0  100.00%
R/tbl_with_pools.R                          64       0  100.00%
R/theme_gtsummary_roche.R                   84       1  98.81%   61
R/utils.R                                   42       0  100.00%
TOTAL                                     4350     124  97.15%

Diff against main

Filename        Stmts    Miss  Cover
------------  -------  ------  --------
R/gg_utils.R       +1       0  +100.00%
TOTAL              +1       0  +0.00%

Results for commit: c1ae490

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[martincadek]

I have read the CLA Document and I hereby sign the CLA

[llrs-roche]

There is no tests or reprex where I can verify that this change fixes the issue mentioned.
But the change looks simple enough. Well done

If you could also add a new point on NEWS.md it would be helpful. Keep in mind to be shorter on the PR.