Export expr in merge_srv#84
Closed
m7pr wants to merge 3 commits into
Closed
Conversation
m7pr
commented
May 12, 2026
Comment on lines
-225
to
-234
| variables_selected <- shiny::eventReactive( | ||
| selectors_unwrapped(), | ||
| { | ||
| shiny::req(selectors_unwrapped()) | ||
| lapply( | ||
| .merge_summary_list(selectors_unwrapped(), join_keys = teal.data::join_keys(data()))$mapping, | ||
| function(selector) unname(selector$variables) | ||
| ) | ||
| } | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This variables_selected is a part of this PR #83
Contributor
|
Code Coverage SummaryDiff against mainResults for commit: 4193fb6 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Tests Summary 1 files 11 suites 18s ⏱️ Results for commit 4193fb6. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance DifferenceAdditional test case details
Results for commit aa92170 ♻️ This comment has been updated with latest results. |
Contributor
|
Here there is an example from Hey, I am observing an issue which potentially is present in all modules, related with If I run the app in But if I run in branch The col relabel is missing |
Contributor
|
@osenan it seems that this is something being done in 
I don't understand why we need to return the edit: See code below, as the code is already executed. If we need to add report, then we can do that earlier on execution inside the module shiny::reactiveConsole(TRUE)
on.exit(reactiveConsole(FALSE))
data <- teal.data::teal_data()
data <- within(data, {
adsl <- data.frame(studyid = "A", usubjid = c("1", "2"), age = c(30, 40))
})
teal.data::join_keys(data) <- teal.data::join_keys(
teal.data::join_key("adsl", "adsl", c("studyid", "usubjid"))
)
selectors <- list(a = shiny::reactive(picks(datasets("adsl", "adsl"), variables("age", "age"))))
out <- shiny::withReactiveDomain(
domain = shiny::MockShinySession$new(),
expr = merge_srv(id = "test", data = shiny::reactive(data), selectors = selectors, output_name = "anl")
)
out$data() |> teal.code::get_code() |> cat()
#> adsl <- data.frame(studyid = "A", usubjid = c("1", "2"), age = c(30, 40))
#> anl <- dplyr::select(adsl, studyid, usubjid, age)
out$expr() |> deparse1() |> cat()
#> [1] "anl <- dplyr::select(adsl, studyid, usubjid, age)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that we can support old code reproduction like