Fixes feedback from CRAN

[averissimo]

Pull Request

Thanks,

Please add \value to .Rd files regarding exported methods and explain
the functions results in the documentation. Please write about the
structure of the output (class) and also what the output means. (If a
function does not return a value, please document that too, e.g.
\value{No return value, called for side effects} or similar)
For more details:
https://contributor.r-project.org/cran-cookbook/docs_issues.html#missing-value-tags-in-.rd-files

-> Missing Rd-tags:
as.picks.Rd: \value
dot-is_delayed.Rd: \value
picks.Rd: \value
ranged.Rd: \value
tidyselectors.Rd: \value
tm_merge.Rd: \value

Please fix and resubmit.

Best,
Konstanze Lauseker (she/her)

[osenan]

LGTM:

Do you know if we also have to add return tag to internal functions we have many with internal documentation but without return tag in:

• call_utils.R
• module_picks.R
• ui_containers.R

Thank you

[averissimo]

@osenan awesome, I've updated with those as well.

[osenan]

Thanks! You can merge, just be sure that this small change is correct.

[osenan]

previously this function was returning the value, now the reactiveValue

[averissimo]

Not really, changing the reactiveVal outputs TRUE (or NULL if condition is not met)

No point in changing the behavior, I'll revert this and change doc accordingly

[averissimo]

@osenan check the latest changes

[llrs-roche]

Do you know if we also have to add return tag to internal functions we have many with internal documentation but without return tag in:

I recommend to run devtools::check_doc_fields() and fix whatever it is reported. I think it is usually requested too, as they are on the manuals even if not indexed.

[averissimo]

Added missing examples of exported functions identified by the wonderful function that @llrs-roche referenced

All the remaining missing @examples are from non-exported functions

[osenan]

Hi, thanks for the changes. I saw errors, notes and warnings if I run devtools::check. I also see missing doc fields

Please fix it and before next review run manually devtools document(), check and check_doc_fields so we are more confident it will pass all checks.

[averissimo]

@osenan those are all non-exported functions.

AFAIK CRAN doesn't like that, I can check the docs for the quote

[osenan]

Ok, but warnings and errors should be addressed, they are actually the only suggestions

[osenan]

LGTM