Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds an Changes
Sequence DiagramsequenceDiagram
actor User
participant CLI
participant UI as "Effect UI"
participant State as "App Auth State"
participant HTTP as "InstantHttpAuthed"
participant Backend as "Dash Backend"
User->>CLI: run `auth client add`
CLI->>UI: prompt/select client type
UI-->>CLI: client type (google)
CLI->>State: getAppsAuth()
State-->>CLI: providers + clients
alt provider exists
CLI->>CLI: use existing provider.id
else
CLI->>HTTP: addOAuthProvider(providerName)
HTTP->>Backend: POST /dash/apps/{appId}/oauth_service_providers
Backend-->>HTTP: provider created
HTTP-->>CLI: provider id
end
CLI->>UI: prompt appType, clientName, clientId, clientSecret?, redirectURI?, skipNonceChecks?
UI-->>CLI: collected inputs
CLI->>HTTP: addOAuthClient(payload, meta)
HTTP->>Backend: POST /dash/apps/{appId}/oauth_clients
Backend-->>HTTP: created client
HTTP-->>CLI: AddOAuthClientResponse
CLI->>User: log created client details and redirect URI
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View Vercel preview at instant-www-js-drewh-control-oauth-from-cli-jsv.vercel.app. |
e0e4b6c to
63d6639
Compare
63d6639 to
7693edd
Compare
7693edd to
3afa789
Compare
3afa789 to
7179cda
Compare
c8438db to
c787732
Compare
stopachka
left a comment
There was a problem hiding this comment.
Awwh yeah let's ship it!
Adds commands to manage OAuth clients from the CLI
Commands:
instant-cli auth client listinstant-cli auth client addinstant-cli auth client deleteAll commands should be fully usable with --yes and have good help text so that agents can use.
Google is the only implemented provider currently.
Reviewing
git switch drewh/control-oauth-from-cliIn a directory with an app, use the commands to add/read/delete auth clients.
Note: Make sure to restart your backend
I have been using this for testing. It requires nushell, but you can always give it to Claude and convert to bash.