Recompute page-space origin coordinates every gesture#8
Open
nikki93 wants to merge 1 commit intoinstea:masterfrom
Open
Recompute page-space origin coordinates every gesture#8nikki93 wants to merge 1 commit intoinstea:masterfrom
nikki93 wants to merge 1 commit intoinstea:masterfrom
Conversation
Collaborator
|
Hi, thanks for contribution! It looks good, I have tested it and it is working on Android. It would be nice to have such functionality also in holo picker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onLayoutis only called when the position is changed within the parent container, but if the parent container itself moves, it's not called. This makesthis._page{X,Y}be out of date. In my case, I have a draggable 'window' as the parent of the color picker and moving it around isn't updatingthis_page{X,Y}. This change makes it sothis_page{X,Y}is computed whenever a new color picking gesture begins so that it's always up to date (unless the color picker moves while gesturing but we can take care of that later...).