Skip to content

Fix Get Segments module with proper structure and registration #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hleova wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Get Segments module with proper structure and registration #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8e11f0
New module28 added
hleova Feb 13, 2026
dc2af77
Fix Get Segments module with proper structure and registration
hleova Feb 15, 2026
762766e
Fix Get Segments module with proper structure and registration (#1)
hleova Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions apps/oss-app-test/src/makecomapp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,22 @@
"scope": "modules/get-users/get-users.scope.iml.json"
}
},
"getSegments": {
"label": "Get Segments",
"description": "Get segment list",
"moduleType": "action",
"actionCrud": "read",
"connection": null,
"altConnection": null,
"codeFiles": {
"communication": "modules/get-segments/get-segments.communication.iml.json",
"staticParams": "modules/get-segments/get-segments.static-params.iml.json",
"mappableParams": "modules/get-segments/get-segments.mappable-params.iml.json",
"interface": "modules/get-segments/get-segments.interface.iml.json",
"samples": "modules/get-segments/get-segments.samples.iml.json",
"scope": "modules/get-segments/get-segments.scope.iml.json"
}
},
"module1": {
"label": "My Module 1",
"description": "Some description",
Expand Down Expand Up @@ -188,6 +204,10 @@
"local": "getUsers",
"remote": "getUsers"
},
{
"local": "getSegments",
"remote": "getSegments"
},
{
"local": "module1",
"remote": "module1"
Expand Down
14 changes: 14 additions & 0 deletions apps/oss-app-test/src/modules/get-segments/get-segments.communication.iml.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
// Request to API endpoint to get segments
"url": "/segments/v1", // Relative to base URL
"method": "GET",
"headers": {}, // Additional HTTP headers
"qs": {
"limit": "{{parameters.limit}}" // Query parameter for pagination
},

// Response handling
"response": {
"output": "{{body.segments}}" // Return segments array from response
}
}
22 changes: 22 additions & 0 deletions apps/oss-app-test/src/modules/get-segments/get-segments.interface.iml.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
[
{
"name": "id",
"type": "text",
"label": "Segment ID"
},
{
"name": "name",
"type": "text",
"label": "Segment Name"
},
{
"name": "description",
"type": "text",
"label": "Description"
},
{
"name": "created_at",
"type": "date",
"label": "Created At"
}
]
10 changes: 10 additions & 0 deletions apps/oss-app-test/src/modules/get-segments/get-segments.mappable-params.iml.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
[
{
"name": "limit",
"type": "number",
"label": "Limit",
"help": "Maximum number of segments to return",
"default": 100,
"required": false
}
]
1 change: 1 addition & 0 deletions apps/oss-app-test/src/modules/get-segments/get-segments.samples.iml.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
Copy link

Copilot AI Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The samples.iml.json file should contain an empty object {}, not an empty array []. This is inconsistent with the existing modules in the codebase (get-users and create-user) which use an empty object for this file.

Suggested change
[]
{}

Copilot uses AI. Check for mistakes.
6 changes: 6 additions & 0 deletions apps/oss-app-test/src/modules/get-segments/get-segments.scope.iml.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"default": {
"label": "Get Segments",
"scopes": []
}
}
Comment on lines +1 to +6
Copy link

Copilot AI Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope.iml.json file should be an array, not an object. The existing modules in the codebase (get-users and create-user) use an empty array format: [] with an optional comment explaining that the code is only relevant for OAuth connections. This file incorrectly uses an object structure with a "default" key.

Suggested change
{
"default": {
"label": "Get Segments",
"scopes": []
}
}
[]

Copilot uses AI. Check for mistakes.
1 change: 1 addition & 0 deletions apps/oss-app-test/src/modules/get-segments/get-segments.static-params.iml.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
Copy link

Copilot AI Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The static-params.iml.json file should have the empty array formatted with brackets on separate lines, consistent with the existing modules in the codebase. The format should be [ on line 1 and ] on line 2, rather than [] on a single line.

Suggested change
[]
[
]

Copilot uses AI. Check for mistakes.
Loading