Skip to content
This repository was archived by the owner on Aug 6, 2025. It is now read-only.

fix: Change pep8 to pycodestyle for fixing failure due to reviewdog GitHub action#22

Merged
NeethuESim merged 1 commit intointel-retail:mainfrom
sbenstewart:main
Feb 4, 2025
Merged

fix: Change pep8 to pycodestyle for fixing failure due to reviewdog GitHub action#22
NeethuESim merged 1 commit intointel-retail:mainfrom
sbenstewart:main

Conversation

@sbenstewart
Copy link
Contributor

@sbenstewart sbenstewart commented Jan 27, 2025

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/core-services/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

We are changing pep8 to pycodestyle , this fixes the reviewdog github action works properly.

Issue this PR will close

close: #21

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/core-services )

@NeethuESim
Copy link
Contributor

@sbenstewart reviewdog failed, can you check what happening ?
image

@sbenstewart
Copy link
Contributor Author

Looking into it.

@sbenstewart
Copy link
Contributor Author

@NeethuES-intel The same fix in other PRs has solved the issue, so just to ensure that this failure is not caused by some sort of cache, can we trigger the review checks once more?

I have another workaround too, and will merge it based on these results.

@Brian-McGinn
Copy link
Contributor

@sbenstewart I ran reviewdog again and the same hadolint error was triggered. I believe this is unrelated to your pep8 fix.

Copy link
Contributor

@NeethuESim NeethuESim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoniomtz
Copy link

is there a way to run reviewdog using this PR changes? @brian-intel @sbenstewart

@NeethuESim
Copy link
Contributor

is there a way to run reviewdog using this PR changes? @brian-intel @sbenstewart

@antoniomtz I checked the logs for reviewdog below, error is related to hadolint now, pep8 error is gone. Not sure what this hadolint error is for.
https://github.com/intel-retail/core-services/actions/runs/12997034007/job/36385192314?pr=22

@NeethuESim
Copy link
Contributor

Good job @sbenstewart @Poojarani22 for working and closing on this issue

@NeethuESim NeethuESim merged commit cebd581 into intel-retail:main Feb 4, 2025
5 of 6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Beginner bug Something isn't working cicd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants