Fix error when no target name is provided in the targets yaml file.#313
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an error case when no target name is provided in the targets YAML file by adjusting how target objects are created and their corresponding temporary directories are determined, as well as relocating the isNoExec function for improved organization.
- Moved the isNoExec function to the end of the file.
- Reordered target object creation in getTargetsFromFile to use newTarget.GetName() for directory creation.
Comments suppressed due to low confidence (1)
internal/common/targets.go:327
- Ensure that using newTarget.GetName() to generate the target-specific directory is intended, especially if the YAML file might not supply an explicit target name.
localTargetDir := path.Join(localTempDir, newTarget.GetName())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.