Enhance core frequency reporting for multi-die architectures

[harp-intel]

Add Cores per Die column, for multi-die architectures

Maximum Frequency
=================
Cores   Cores per Die   SSE   AVX2   AVX512   AVX512H   AMX
-----   -------------   ---   ----   ------   -------   ---
1-44    1-22            3.8   3.6    3.5      3.5       3.0
45-52   23-26           3.8   3.5    3.2      3.2       2.8
53-60   27-30           3.8   3.4    3.1      3.1       2.6
61-68   31-34           3.8   3.2    2.9      2.6       2.2
69-72   35-36           3.8   3.2    2.8      2.5       2.2
73-76   37-38           3.8   3.1    2.8      2.5       2.2
77-80   39-40           3.8   3.0    2.7      2.4       2.1
81-86   41-43           3.8   3.0    2.7      2.4       2.1

[Copilot]

Pull Request Overview

This pull request enhances core frequency reporting for multi‐die architectures by adding a new “Cores per Die” column and updating related bucket calculations and table definitions. Key changes include updating header comments and diff logic in table_helpers.go, adding new bucket variables and calculations, and revising field definitions in table_defs.go and benchmarking_table_helpers.go to support the new reporting format.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
internal/report/table_helpers.go	Updated header comments and bucket calculation logic for multi‐die architectures.
internal/report/table_defs.go	Revised table field definitions (including new Models entry) for accelerator reporting.
internal/report/benchmarking_table_helpers.go	Adjusted comment and index descriptions in bucketsToCoresFreqs function.

Comments suppressed due to low confidence (1)

internal/report/table_defs.go:283

• [nitpick] Consider adding further documentation or clarifying comments for the Models field to help maintainers understand the significance of the listed model numbers.

Models:  []string{"143", "207", "173", "175", "221"}, // Sapphire Rapids, Emerald Rapids, Granite Rapids, Sierra Forest, Clearwater Forest

[Copilot]

Pull Request Overview

This PR enhances core frequency reporting for multi‐die architectures by adding a new "Cores per Die" column and refactoring the related spec frequency bucket processing.

• Update MSR conversion functions to use native int values.
• Refactor functions that generate spec frequency buckets and adjust field names accordingly.
• Update table definitions and frequency table generation logic for core frequency and accelerator tables.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
internal/report/table_helpers.go	Updates to the MSR conversion function and spec frequency bucket computation.
internal/report/table_defs.go	Adjustments in table definitions and core frequency field generation logic.
internal/report/benchmarking_table_helpers.go	Refactoring of frequency bucket parsing and table frequency processing functions.

Comments suppressed due to low confidence (2)

internal/report/table_helpers.go:200

• Converting MSR values from int64 to int may risk overflow if the values exceed the int range; please confirm that the expected MSR values are safely representable as int.

func convertMsrToDecimals(msr string) (decVals []int, err error) {

internal/report/table_defs.go:2078

• Using sequential core numbering (i+1) in cpuFrequencyTableValues replaces the previous bucket-derived core counts; please verify that this simplified core mapping accurately reflects the intended frequency reporting for multi-die architectures.

fields[coresIdx].Values = append(fields[coresIdx].Values, fmt.Sprintf("%d", i+1))