Fix frequency benchmark table values condition to allow for minimum o…#318
Merged
Conversation
…ne frequency buckets Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the condition for processing frequency buckets in the benchmark table values to allow for exactly two frequency buckets, fixing an edge-case issue.
- Changed conditional check from "> 2" to ">= 2" to include the minimum expected number of buckets.
Comments suppressed due to low confidence (1)
internal/report/table_defs.go:1989
- The updated condition now allows exactly 2 frequency buckets. Please confirm that this new logic matches the intended behavior for processing buckets.
if err == nil && len(frequencyBuckets) >= 2 {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ne frequency buckets