Skip to content

fix retrieval of all-core max frequency for multi-die architectures#323

Merged
harp-intel merged 2 commits into
mainfrom
allcoremaxfreqbug
Apr 28, 2025
Merged

fix retrieval of all-core max frequency for multi-die architectures#323
harp-intel merged 2 commits into
mainfrom
allcoremaxfreqbug

Conversation

@harp-intel
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
@harp-intel harp-intel requested a review from Copilot April 28, 2025 15:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@harp-intel harp-intel requested a review from Copilot April 28, 2025 15:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the frequency retrieval logic for multi-die architectures by switching from a column-based lookup to using SSE frequency buckets. Key changes include:

  • Refactoring maxFrequencyFromOutput to extract the maximum single-core frequency from the SSE buckets.
  • Modifying allCoreMaxFrequencyFromOutput to retrieve the maximum all-core frequency using the last SSE bucket.
  • Introducing a helper function, getSSEFreqsFromBuckets, to extract SSE frequencies from the provided buckets.

Comment thread internal/report/table_helpers.go
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
@harp-intel harp-intel merged commit 69aadee into main Apr 28, 2025
3 checks passed
@harp-intel harp-intel deleted the allcoremaxfreqbug branch April 28, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants