Implement concurrent targets in config command

[harp-intel]

No description provided.

[Copilot]

Pull Request Overview

This PR implements concurrent processing of targets in the config command and updates related data structures. Key changes include:

• Refactoring TargetScriptOutputs in common.go to use exported field names.
• Converting synchronous configuration changes into concurrent operations with improved spinner usage and error reporting.
• Enhancing the printConfig logic to process and display table outputs concurrently.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
internal/common/common.go	Updated struct field names for TargetScriptOutputs for concurrency support.
cmd/config/config.go	Refactored the config command to run target operations concurrently with improved status updates and error handling.

Comments suppressed due to low confidence (1)

internal/common/common.go:46

• [nitpick] The renaming of the struct fields to exported names is clear; ensure that all consuming code and documentation are updated to reflect these changes.

type TargetScriptOutputs struct {
	TargetName    string
	ScriptOutputs map[string]script.ScriptOutput
	TableNames    []string
}

[Copilot]

Pull Request Overview

This PR implements concurrent updates to the configuration command by refactoring flag functions and target operations to use asynchronous channel‐based error handling. Key changes include:

• Renaming struct fields and updating accessors in internal/common/common.go to export necessary values.
• Changing flag definitions and their corresponding set functions (in cmd/config/flag.go and flag_groups.go) to accept channel and index parameters to support concurrent execution.
• Refactoring the configuration update and reporting logic in cmd/config/config.go to run updates concurrently using goroutines and channels.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
internal/common/common.go	Updates exported field names and accessors for consistency.
cmd/config/flag_groups.go	Adds an "Other Options" group and updates flag callback signatures.
cmd/config/flag.go	Modifies flag functions to include concurrency parameters.
cmd/config/config.go	Refactors config update logic for concurrent target processing.

Comments suppressed due to low confidence (2)

cmd/config/config.go:176

• Consider assigning len(successMessages)-1 to a local variable before launching the goroutine to ensure the intended index is reliably captured.

go flag.intSetFunc(value, myTarget, localTempDir, channelSetComplete, len(successMessages)-1)

cmd/config/config.go:240

• The error received from channelError is logged but not propagated back to the caller, which could lead to silent failures. Consider returning or otherwise handling the error to ensure proper error reporting.

select { case scriptOutputs := <-channelTargetScriptOutputs: ... case err := <-channelError: ... }