create tarball of output files in output directory#360
Merged
Conversation
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces functionality to create a tarball (TGZ) of generated output files—raw files, report files, and the log file—for non-Metrics commands. It also adds corresponding tests and integrates the tarball creation into the application context when debugging is enabled.
- Added CreateFlatTGZ function in util.go to generate a flat tarball.
- Extended tests in util_test.go to cover both success and failure scenarios.
- Updated application context and startup logic in common.go and cmd/root.go to support tarball generation.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/util/util_test.go | Added tests for CreateFlatTGZ functionality. |
| internal/util/util.go | Implemented CreateFlatTGZ for creating a flat tarball. |
| internal/common/common.go | Integrated tgz archive creation when debugging is enabled. |
| cmd/root.go | Updated timestamp usage and log file handling in app init. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all commands except Metrics, this PR creates a tarball, when in debug mode, that contains the generated raw files, report files, and the log file.