add NIC vendor and model IDs to report#366
Merged
Merged
Conversation
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances NIC reporting by including vendor and model identifiers alongside existing vendor/model names.
- Adds shell commands to extract
Vendor IDandModel IDin the NIC inspection script. - Extends the
nicInfostruct and parsing logic to capture these IDs. - Updates table definitions to display IDs in the report columns.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/script/script_defs.go | Echoes Vendor ID and Model ID per interface |
| internal/report/table_helpers.go | Adds VendorID and ModelID fields and parsing |
| internal/report/table_defs.go | Renames columns to include (ID) and appends IDs |
Comments suppressed due to low confidence (1)
internal/report/table_helpers.go:1333
- The new
VendorIDandModelIDfields are not covered by existing unit tests. Add tests forparseNicInfoto verify that both IDs are correctly parsed from script output.
VendorID string
…ability Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.