Don't stomp on "VERBOSE" variable - #479
Open
berrange wants to merge 1 commit into
Open
Conversation
The VERBOSE=1 variable is set to make various cmake builds run in verbose mode. It must not be used for other purposes by the makefiles otherwise the usage will clash. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
berrange
force-pushed
the
make-verbose
branch
from
February 5, 2026 12:07
9ed8d58 to
c63ab00
Compare
mbronk-intc
reviewed
Jul 24, 2026
| endif | ||
|
|
||
| VERBOSE := @ | ||
| CMD := @ |
Contributor
There was a problem hiding this comment.
CMD is a little cryptic and hard to reason about wrt. the intent.
I'd suggest sth more akin to this:
# Quiet (suppress cmd echo)
Q := @
ifeq ($(V),1)
Q :=
endif
ifdef VERBOSE
Q :=
endifI.e move from VERBOSE to Q (which, allegedly, may be even more idiomatic), while also honoring cmake's VERBOSE, aka.
make V=1 and make VERBOSE=1 both producing a verbose variant.
Note that, technically make VERBOSE=0 would also be verbose, but I think it's actually consistent w/ CMake (IIRC it does #ifdef not #if, but may be wrong here)
Contributor
Author
There was a problem hiding this comment.
Yes, that all makes sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VERBOSE=1 variable is set to make various cmake builds run in verbose mode. It must not be used for other purposes by the makefiles otherwise the usage will clash, and that prevents switching Cmake into verbose mode.