pcsclient: remove leftover debugging 'print(args)' statement#491
Open
berrange wants to merge 1 commit into
Open
pcsclient: remove leftover debugging 'print(args)' statement#491berrange wants to merge 1 commit into
berrange wants to merge 1 commit into
Conversation
Dumping the python "Namespace" object to stdout after parsing argv serves no end-user purpose: $ pcsclient.py cache Namespace(command='cache', url=None, input_file=None, output_dir=None, sub_dir=False, expire=None, tcb_update_type=None, func=<function pcs_cache at 0x7ff9102ea770>) Please note: A prompt may appear asking for your keyring password to access stored credentials. Please input ApiKey for Intel PCS: Remove what is presumably a leftover debugging statement: $ pcsclient.py cache Please note: A prompt may appear asking for your keyring password to access stored credentials. Please input ApiKey for Intel PCS: Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
berrange
force-pushed
the
pcsclient-debug
branch
from
July 24, 2026 10:15
d3bb1cb to
7b96d1d
Compare
Contributor
Author
|
Rebased to latest HEAD |
mbronk-intc
approved these changes
Jul 24, 2026
mbronk-intc
left a comment
mbronk-intc
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Semi-related: @mtomczew - please take a look 👀 , if you wouldn't want/need to have it replaced with a proper (verbose-mode-only?) CLI print-out.
mtomczew
approved these changes
Jul 24, 2026
mtomczew
left a comment
mtomczew
left a comment
Contributor
There was a problem hiding this comment.
I agree this log line looks weird, especially func value. Maybe later we will add some more verbose logs, but for now removal of this line is OK for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dumping the python "Namespace" object to stdout after parsing argv serves no end-user purpose:
Remove what is presumably a leftover debugging statement: