This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][Matrix]Add test for all sizes#1628
Draft
YuriPlyakhin wants to merge 10 commits into
Draft
Conversation
dkhaldi
reviewed
Mar 10, 2023
dkhaldi
left a comment
dkhaldi
left a comment
There was a problem hiding this comment.
LGTM but we should add the XMX8 version of the test so it gets tested on ATS-M as well
dkhaldi
reviewed
Mar 10, 2023
Updated tests to pass on GPU, splitting compilation of each kernel. Added new environment variables for different optimization modes Added XMX8 variant.
cperkinsintel
approved these changes
Mar 11, 2023
dkhaldi
suggested changes
Mar 13, 2023
dkhaldi
left a comment
dkhaldi
left a comment
There was a problem hiding this comment.
I prefer the way it was with having multiple tests rather than macros. what do you think?
It is okay to set it to xfail until we fix the bug
YuriPlyakhin
marked this pull request as draft
March 13, 2023 15:56
dkhaldi
reviewed
Mar 16, 2023
dkhaldi
marked this pull request as ready for review
March 16, 2023 18:00
YuriPlyakhin
marked this pull request as draft
March 16, 2023 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.