Skip to content

[SYCL][NFC] minor updates #22037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cperkinsintel wants to merge 2 commits into
base: sycl
Choose a base branch
from
+2 −3
Open

[SYCL][NFC] minor updates #22037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63b8afc
some code was moved, but the comment overlooked
cperkinsintel May 14, 2026
1106474
unused include
cperkinsintel May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/include/sycl/detail/get_kernel_info_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class DeviceKernelInfo;
// Fetches the cached kernel via the program manager and dispatches to
// get_kernel_device_specific_info. Validation that kernel_impl::get_info
// performs is replicated in the library-side definition (see
// validateDeviceSpecificQuery in source/detail/get_device_kernel_info.cpp).
// validateDeviceSpecificQuery in source/detail/get_kernel_info_impl.cpp).
// Explicit instantiations for every kernel_device_specific descriptor form
// the ABI boundary; user code reaches these through the public entry points
// in ext/oneapi/get_kernel_info.hpp.
Expand Down
1 change: 0 additions & 1 deletion sycl/source/detail/get_kernel_info_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

#include <detail/context_impl.hpp>
#include <detail/device_impl.hpp>
#include <detail/global_handler.hpp>
#include <detail/kernel_info.hpp>
#include <detail/program_manager/program_manager.hpp>

Expand Down
2 changes: 1 addition & 1 deletion sycl/source/detail/kernel_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ inline context kernel_impl::get_info<info::kernel::context>() const {
}

// NOTE: the global_work_size and spill_memory_size pre-query checks below are
// mirrored in validateDeviceSpecificQuery (get_device_kernel_info.cpp), which
// mirrored in validateDeviceSpecificQuery (get_kernel_info_impl.cpp), which
// serves the ext::oneapi::get_kernel_info<KernelName, Param> fast path that
// does not go through kernel_impl. Keep both in sync.
template <typename Param>
Expand Down
Loading