[SYCL][NFC] Drop <optional> from half_type.hpp / bfloat16.hpp#22039
Open
koparasy wants to merge 2 commits into
Open
[SYCL][NFC] Drop <optional> from half_type.hpp / bfloat16.hpp#22039koparasy wants to merge 2 commits into
koparasy wants to merge 2 commits into
Conversation
half_type.hpp included <optional> only to make std::hash's primary
template visible for the std::hash<sycl::half> specialization. Replace
with a forward declaration (`namespace std { template <class> struct
hash; }`) and inline the hash body so it no longer calls
std::hash<uint16_t>{}, which requires the primary definition. Same
treatment in bfloat16.hpp (already had sycl::bit_cast in scope).
Saves the <optional> transitive chain (~30 ms parse + 60+ headers) on
every TU that pulls sycl::half.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
half_type.hpp included only to make std::hash's primary template visible for the std::hashsycl::half specialization. Replace with a forward declaration (
namespace std { template <class> struct hash; }) and inline the hash body so it no longer calls std::hash<uint16_t>{}, which requires the primary definition. Same treatment in bfloat16.hpp (already had sycl::bit_cast in scope).Saves the transitive chain (~30 ms parse + 60+ headers) on every TU that pulls sycl::half.