[SYCL][Unit] Fix crash when user sets ONEAPI_DEVICE_SELECTOR in shell#22684
Merged
againull merged 1 commit intoJul 21, 2026
Merged
Conversation
The mock adapter is not a real device backend, but ONEAPI_DEVICE_SELECTOR and SYCL_DEVICE_FILTER are still applied to it by platform_impl. If either is set in the ambient shell to a backend that doesn't match UrMock's declared Backend (opencl by default), the mock device gets filtered out and every mock-based unit test aborts with "No device of requested type available" instead of running deterministically. Clear both env vars at the top of the UrMock constructor, before any SYCL runtime code caches their value. Fixes case 1 in intel#22683. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
dm-vodopyanov
approved these changes
Jul 20, 2026
Contributor
Author
|
@intel/llvm-gatekeepers please merge, thanks. This PR fixes local check-sycl-unittests. e2e fails on BMG are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mock adapter is not a real device backend, but ONEAPI_DEVICE_SELECTOR and SYCL_DEVICE_FILTER are still applied to it by platform_impl. If either is set in the ambient shell to a backend that doesn't match UrMock's declared Backend (opencl by default), the mock device gets filtered out and every mock-based unit test aborts with "No device of requested type available" instead of running deterministically.
Clear both env vars at the top of the UrMock constructor, before any SYCL runtime code caches their value.
Fixes case 1 in #22683.