[SYCL][Unit] Mock UR_DEVICE_INFO_PLATFORM in UrMock#22685
Merged
Conversation
Fixes `SYCL_UR_TRACE=1 ninja check-sycl-unittests` crash in intel#22683. mock_urDeviceGetInfo() fell through to the default zero-fill case for UR_DEVICE_INFO_PLATFORM, so device::get_info<info::device::platform>() returned a platform wrapping a null UR handle. This is latent unless something queries that platform afterwards, which detail::traceDeviceSelection() does whenever SYCL_UR_TRACE is enabled, causing urPlatformGetInfo to fail with UR_RESULT_ERROR_INVALID_NULL_HANDLE and the process to abort on the uncaught exception. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
cperkinsintel
approved these changes
Jul 20, 2026
Contributor
Author
|
@intel/llvm-gatekeepers please merge, thanks. This PR fixes local check-sycl-unittests. e2e fails on Arc and BMG are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
SYCL_UR_TRACE=1 ninja check-sycl-unittestscrash in #22683.mock_urDeviceGetInfo() fell through to the default zero-fill case for UR_DEVICE_INFO_PLATFORM, so device::get_infoinfo::device::platform() returned a platform wrapping a null UR handle. This is latent unless something queries that platform afterwards, which
detail::traceDeviceSelection() does whenever SYCL_UR_TRACE is enabled, causing urPlatformGetInfo to fail with UR_RESULT_ERROR_INVALID_NULL_HANDLE and the process to abort on the uncaught exception.