[clang-linker-wrapper] Restore sycl-post-link check and fix comment wording in clang-linker-wrapper test#22694
Merged
Merged
Conversation
…ording in clang-linker-wrapper test Addresses PR intel#22645 review feedback: restore the dropped assertion that sycl-post-link's -o target isn't comma-prefixed when -device is supplied via split --device-linker= tokens, and clean up the surrounding comment wording.
Contributor
Author
|
@intel/dpcpp-clang-driver-reviewers, please, take a look. Just 11 lines of changes in the test (mostly comments). |
mdtoguchi
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses PR #22645 review feedback: restore the dropped assertion
that sycl-post-link's -o target isn't comma-prefixed when -device is
supplied via split --device-linker= tokens, and clean up the
surrounding comment wording.