[Driver][NFC] Update test to not pull in device libraries#22695
Merged
Conversation
This test does basic checks with -### and does an additional compilation that generates a preprocessed file to test for potential triple mismatch when extracting PCH files. When this is tested without any device libraries the compilation fails due to errors. Update the RUN lines to not pull in any device libraries. These are not important for the test.
srividya-sundaram
approved these changes
Jul 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates the SYCL Windows effective triple driver test to avoid pulling in device libraries, preventing compilation failures when device libs aren’t available while keeping the test focused on effective triple/PCH extraction behavior.
Changes:
- Adds
--no-offloadliband-fno-sycl-instrument-device-codeto the relevantRUN:invocations. - Keeps the existing
FileCheckassertions intact while adjusting driver invocation inputs.
mdtoguchi
marked this pull request as ready for review
July 21, 2026 00:02
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test does basic checks with -### and does an additional compilation that generates a preprocessed file to test for potential triple mismatch when extracting PCH files. When this is tested without any device libraries the compilation fails due to errors. Update the RUN lines to not pull in any device libraries. These are not important for the test.