[SYCL][libclc][CUDA] Add native math extension#5747
Merged
Conversation
This patch extends the native math definitions in order to include builtins out of the current SYCL specification. In particular, this patch adds a tanh builtin for floats/halfs and a exp2 builtin for halfs which are mapped to instructions introduced for sm_75 and above.
pgorlani
added a commit
to pgorlani/llvm-test-suite
that referenced
this pull request
Mar 7, 2022
This patch adds tests for intel/llvm#5747
This was referenced Mar 7, 2022
gmlueck
reviewed
Mar 7, 2022
gmlueck
reviewed
Mar 7, 2022
gmlueck
previously approved these changes
Mar 7, 2022
gmlueck
left a comment
gmlueck
left a comment
Contributor
There was a problem hiding this comment.
Spec changes look good to me.
elizabethandrews
previously approved these changes
Mar 7, 2022
bader
reviewed
Mar 9, 2022
pgorlani
dismissed stale reviews from smanna12, elizabethandrews, and gmlueck
via
March 9, 2022 11:36
07aa4e5
bader
approved these changes
Mar 9, 2022
bader
left a comment
bader
left a comment
Contributor
There was a problem hiding this comment.
libclc changes look good to me.
mlychkov
approved these changes
Mar 10, 2022
mlychkov
left a comment
mlychkov
left a comment
Contributor
There was a problem hiding this comment.
Changes in llvm inrtinsics definitions LGTM.
Contributor
|
@intel/llvm-reviewers-runtime, ping. |
alexbatashev
approved these changes
Mar 10, 2022
pgorlani
added a commit
to pgorlani/llvm-test-suite
that referenced
this pull request
Apr 4, 2022
This patch adds tests for intel/llvm#5747
steffenlarsen
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Jun 23, 2022
This patch adds tests for intel/llvm#5747
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
This patch adds tests for intel#5747
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch extends the native math definitions in order to include builtins out of the current SYCL specification.
In particular, this patch adds a
tanhbuiltin for floats/halfs and a exp2 builtin forhalfswhich are mapped to instructions introduced forsm_75and above.Tests in intel/llvm-test-suite#895