devtools improvements#657
Open
desmonddak wants to merge 25 commits into
Open
Conversation
…al/instance naming routine names
Introduces a singleton service registry (ModuleServices) that provides a unified query surface for DevTools and inspection tools. Module.build() now registers the root module with ModuleServices.instance. Also adds SvService which wraps SystemVerilog synthesis and registers with ModuleServices for DevTools access to SV metadata. This is a clean separation: no netlist code is included. The netlist branch will later extend ModuleServices with a netlistService field.
DevTools now evaluates ModuleServices.instance.hierarchyJSON instead of ModuleTree.instance.hierarchyJSON. ModuleServices delegates to ModuleTree internally, so behavior is unchanged.
…into devtool_utilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Our devtools implementation has significant gaps, even as a shell, and this PR is to prepare it to support more functionality by making at least the shell work properly.
Currently, it would not run using
Open DevTools in Browserbecause of a service worker problem (waiting for one that never gets started). It also would only connect to the first isolate running at top level (say in an example) and not be able to connect to an isolate in a test function inside a main().So now the shell can at least connect to the first available debugger session using
Open DevTools in Browser.I added some basic widget utilities that will be used in upcoming enhancements to devtools: a Help widget and a Snapshot widget (allowing for screenshots of widget panes).
So, the shell is now workable; it can connect to a ROHD debug session, load its design into the module tree widget, and show the details pane with other functionality stubbed out but plumbed.
Related Issue(s)
Testing
Ran the build_web.sh
Ran a debug session in the test area on a simulation.
Ran a devtools session and connected to the debugger, displayed the details pane, took snapshots.
Backwards-compatibility
Some ambiguity on the service worker connection (we don't seem to need it after extensive testing in a more complex devtools implementation)
Documentation
No update required.