This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Added ARC I2C interfae library#4
Closed
xieqi wants to merge 1 commit intointel:masterfrom
xieqi:master
Closed
Conversation
Support I2C controller ACI_I2C0 and ARC_I2C1 of the ARC Core.
| author=Intel | ||
| maintainer=Intel | ||
| email=dave@emutex.com | ||
| sentence=This is a I2C libraries from the Arc core that are specific to the Randon+ hardware platform. |
Contributor
|
Are these all new files? or are they ported from somewhere? |
| version=1.0 | ||
| author=Intel | ||
| maintainer=Intel | ||
| email=dave@emutex.com |
Contributor
There was a problem hiding this comment.
Is this email address accurate?
Contributor
|
The file ARC_I2C.cpp is almost an exact duplicate of the existing file libraries/Wire/src/Wire.cpp; Besides the name change from "Wire" to "ARC_I2C", I can see perhaps 4-5 lines that are different. Maybe the right approach here is to modify the existing driver so that a controller can be selected? |
Contributor
|
The two example sketches, also, are slightly modified versions of two existing Wire library examples. -1 |
eriknyquist
suggested changes
Oct 31, 2016
Contributor
eriknyquist
left a comment
eriknyquist
left a comment
There was a problem hiding this comment.
@xieqi any updates on this?
Contributor
|
This PR is replaced by, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support I2C controller ACI_I2C0 and ARC_I2C1 of the ARC Core.
@SidLeung