Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes default configuration files that are no longer needed and updates the system to use built-in hardcoded defaults instead. The changes streamline the installation process and clarify that Claude Code 2 + Opus is the primary focus, with emphasis on using file-based @-mentions for subagents.
- Removes legacy default config files (
icc.config.default.json,icc.workflow.default.json) and documentation (pr-body.md,ARCHITECTURAL_FAILURE_DIAGNOSIS.md) - Updates config loader to use hardcoded defaults directly instead of searching for default files
- Updates all installation scripts, documentation, and tests to reflect the removal of default config files
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/run-tests.sh | Updates config path to use sample config instead of removed default |
| src/hooks/lib/config-loader.js | Removes default file loading logic, starts with hardcoded defaults |
| src/commands/icc-get-setting.md | Updates documentation to reference built-in defaults |
| src/behaviors/shared-patterns/configuration-patterns.md | Updates config hierarchy documentation |
| src/behaviors/config-system.md | Updates config system documentation |
| pr-body.md | Removes obsolete PR template file |
| install.ps1 | Removes default config file installation logic |
| icc.workflow.default.json | Removes default workflow configuration file |
| icc.config.default.json | Removes default configuration file |
| docs/configuration-guide.md | Updates configuration hierarchy documentation |
| best-practices/development/config-loading-dual-context.md | Updates example code to reference user configs instead of defaults |
| ansible/roles/intelligent_claude_code/tasks/main.yml | Removes default config and workflow file installation |
| README.md | Updates scope description and clarifies @-mention usage with lowercase filenames |
| Makefile | Updates help text to indicate CONFIG_FILE is optional |
| ARCHITECTURAL_FAILURE_DIAGNOSIS.md | Removes obsolete architectural analysis document |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 93 out of 94 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 97 out of 98 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 104 out of 105 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 133 out of 134 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 139 out of 140 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 142 out of 143 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 145 out of 146 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // These keywords were removed from summaryPatterns because they're too broad | ||
| assert( | ||
| !isSummaryFile('docs/configuration-best-practices.md', PROJECT_ROOT), | ||
| !isSummaryFile('docs/configuration-standards.md', PROJECT_ROOT), |
There was a problem hiding this comment.
The test file references a renamed documentation file (configuration-standards.md) but this rename is not shown in the PR. Either the file should be renamed in this PR, or the test should reference the actual filename that exists.
| 'VERSION', 'README.md', 'CLAUDE.md', 'CHANGELOG.md', | ||
| 'LICENSE', 'LICENSE.md', '.gitignore', 'package.json', | ||
| 'icc.config.json', 'icc.workflow.json' | ||
| 'icc.config.json' |
There was a problem hiding this comment.
The reference to icc.workflow.json is being removed from the allowed files list, but the PR description states this file is being removed from default configs. Verify that removing this from the allowed list won't cause issues if users still have this file in their projects. Consider whether this should remain as an allowed root file even if it's no longer provided by default.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 146 out of 147 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 168 out of 177 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
summaries/hook-validation-matrix-2025-11-05.md:1
- The date '2025-11-05' appears to be in the future. The current date is January 9, 2026, but this file shows a date from November 2025. If this is a typo or incorrect date, it should be corrected to reflect the actual creation date.
summaries/test-qa-complete-summary-2025-11-06.md:1 - The date '2025-11-06' appears to be in the future relative to the file's expected timeline. Since the current date is January 9, 2026, but this shows November 2025, this may indicate the file contains backdated content that should be verified.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| **P3:** Complexity analysis selects AgentTask-Template (nano/tiny/medium/large/mega) | ||
| **P4:** Memory-first approach before all work and questions | ||
| **P5:** Direct execution from AgentTask-Template context | ||
| **P6:** Knowledge capture and best-practices promotion after execution | ||
|
|
There was a problem hiding this comment.
The removal of P6 creates a gap in the numbering sequence (P1-P5, then missing P6). Consider renumbering P3-P5 to P3-P5 without gaps, or if P6 is being removed intentionally, document why the sequence now ends at P5 instead of continuing.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 172 out of 183 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 172 out of 183 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
summaries/test-execution-report-2025-11-06.md:1
- The date "2025-11-06" is in the future. The knowledge cutoff is January 2025, and the current date is January 9, 2026. While this could be a typo (perhaps meant to be 2024-11-06), this file is being deleted so no fix is needed, but this should be noted for awareness.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| : path.resolve(projectRoot, filePath); | ||
|
|
||
| const allowedDirs = ['stories', 'bugs', 'docs', 'src', 'tests', 'config', 'agenttasks']; | ||
| const allowedDirs = ['stories', 'bugs', 'docs', 'src', 'tests', 'agenttasks']; |
There was a problem hiding this comment.
The removal of 'config' from allowedDirs changes the validation behavior for files in the config/ directory. Ensure there are tests covering this change to verify that config/ files are now correctly identified as summary files when appropriate.
1 participant
Summary
Testing