-
Notifications
You must be signed in to change notification settings - Fork 4
refactor(skills): convert to canonical Step N — Title headings #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bad4526
refactor: convert iikit skills to canonical Step N — Title headings
jbaruch 33b5b67
fix(skills): address gh-aw skill-authoring findings
jbaruch 91db4b7
fix(skills): update stale §6.6 references to §5.6
jbaruch 17c7dfd
fix(skills): correct JSON field name and dedupe Step 4 reference
jbaruch 299791f
fix(skills): flatten decimal sub-step labels, fix lingering refs
jbaruch fc1e4c9
fix(tests): tighten Step 5 bold-label presence checks
jbaruch 381d341
fix(skills): disambiguate 'step 1' references in Prerequisites Check
jbaruch a579c45
fix(skills): add explicit step continuations per skill-authoring
jbaruch aaa65ed
fix(skills): move continuations outside fenced output templates
jbaruch 1d7a5a8
fix(iikit-01-specify): make Step 1 continuation conditional
jbaruch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jbaruch/coding-policy: skill-authoringrequires: "State continuations explicitly ("Proceed immediately to Step N"); do not rely on implicit reading order."This conversion creates the flat Step heading, but Step 1 has no explicit handoff to Step 2; the same pattern appears across the sequential skill conversions. Add explicit continuation text to each non-terminal step, for example
Proceed immediately to Step 2., or another policy-compliant handoff.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in a579c45 — added 83 explicit step continuations across 11 SKILL.md files. Each non-terminal Step now ends with
Proceed immediately to Step N+1.and each terminal Step ends withFinish here.(which also applies to all 5 iikit-core router steps since they each terminate).