Skip to content

Comments

[PB-5714] Split tsdown#27

Merged
TamaraFinogina merged 12 commits intomasterfrom
split_tsdown
Feb 18, 2026
Merged

[PB-5714] Split tsdown#27
TamaraFinogina merged 12 commits intomasterfrom
split_tsdown

Conversation

@TamaraFinogina
Copy link
Contributor

@TamaraFinogina TamaraFinogina commented Jan 23, 2026

Description

Make sure that we don't need to load the entire library if we just use a few functions

Related Issues

Relates to PB-5714

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Additional Notes

without any import shaking:
image

with this PR:

image

@TamaraFinogina TamaraFinogina self-assigned this Jan 23, 2026
@TamaraFinogina TamaraFinogina changed the title [_] Split tsdown [PB-5714] Split tsdown Jan 23, 2026
@TamaraFinogina TamaraFinogina marked this pull request as ready for review February 17, 2026 17:26
"idb": "^8.0.3",
"uuid": "^13.0.0"
},
"exports": {
Copy link
Contributor

@larryrider larryrider Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im still not sure about having to define this on every 'class'/'service' of the project
But if its the only way, maybe it could be a good idea to add to the Readme.md some instructions so its clear how to implement a new functionality (like where we should add it -> ‎package.json, tsdown.config.ts, ‎src/index.ts, etc)

wdyt? @TamaraFinogina

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defining exports is the only way it worked. Not sure if it's because I'm importing this library in commonjs projects and they need some help or not. I'll add read.me

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe could use wildcard exports :)

  "exports": {
    ".": {
      "types": "./dist/index.d.ts",
      "import": "./dist/index.mjs",
      "require": "./dist/index.js"
    },
    "./*": {
      "types": "./dist/*.d.ts",
      "import": "./dist/*.mjs",
      "require": "./dist/*.js"
    }
  }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CandelR Seems to be working. Thanks!!!

@sonarqubecloud
Copy link

@TamaraFinogina TamaraFinogina merged commit 120b299 into master Feb 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants