[PB-5650]: Add auto-delete column to trash view#1799
Open
terrerox wants to merge 6 commits intofeature/automatic-trash-disposalfrom
Open
[PB-5650]: Add auto-delete column to trash view#1799terrerox wants to merge 6 commits intofeature/automatic-trash-disposalfrom
terrerox wants to merge 6 commits intofeature/automatic-trash-disposalfrom
Conversation
Add a new "Auto-delete" column in the trash list that displays the number of days until an item is permanently deleted. The column shows "In X day(s)" with a warning icon, and highlights items in red when they have 2 days or less remaining. Changes: - Add caducityDate field to DriveFileData and DriveFolderData types - Add "Auto-delete" translation key to English locale - Create skinSkeletonTrash for trash view loading state - Add auto-delete column header to trash list (non-orderable) - Display auto-delete countdown with WarningCircle icon in list items - Calculate days until deletion from caducityDate field - Apply red text styling for urgent items (≤2 days remaining)
Deploying drive-web with
|
| Latest commit: |
4289492
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://77d72e10.drive-web.pages.dev |
| Branch Preview URL: | https://feature-automatic-trash-colu.drive-web.pages.dev |
CandelR
reviewed
Jan 13, 2026
Comment on lines
106
to
116
| interface ListHeaderItem { | ||
| label: string; | ||
| width: string; | ||
| name: 'type' | 'name' | 'updatedAt' | 'size' | 'caducityDate'; | ||
| orderable: boolean; | ||
| defaultDirection: 'ASC' | 'DESC'; | ||
| buttonDataCy?: string; | ||
| textDataCy?: string; | ||
| } | ||
|
|
||
| const getListHeaders = (translate: (key: string) => string, isRecents: boolean, isTrash: boolean): ListHeaderItem[] => { |
Collaborator
There was a problem hiding this comment.
Maybe we can move this outside in order to keep it separately and make it easy to maintain. We could add it in a DriveExplorerList directory and add all components related with this DriveExplorerList
| days: number, | ||
| translate: (key: string, options?: { count?: number }) => string, | ||
| ): { text: string; isUrgent: boolean } => { | ||
| const isUrgent = days <= 2; |
Collaborator
There was a problem hiding this comment.
why 2? Add it to a descriptive variable
| }; | ||
|
|
||
| const DriveExplorerListItem = ({ item }: DriveExplorerItemProps): JSX.Element => { | ||
| const getAutoDeleteDisplay = ( |
Collaborator
There was a problem hiding this comment.
I think that this function name does not reflect what does, maybe getAutoDeleteStatusInfo or something similar fits better
| }; | ||
|
|
||
| const DriveExplorerListItem = ({ item }: DriveExplorerItemProps): JSX.Element => { | ||
| const getAutoDeleteDisplay = ( |
Collaborator
There was a problem hiding this comment.
Maybe we can add memoization for this function
CandelR
approved these changes
Jan 14, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new "Auto-delete" column in the trash list that displays the number of days until an item is
permanently deleted. The column shows "In X day(s)" with a warning icon, and highlights items in red when
they have 2 days or less remaining.
Changes:
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes