Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From @manuel489 at interscript/interscript-ruby#11
From @manuel489
Hi Ron,
I have several transliterations set already. But I'd like you to review this one to see if I'm on track.
Thanks!
From @andrew2net
We need to define at least one test case for each transliteration system. Please add
sourceandexpectedin thetestsection.From @ronaldtse
Right, but it seems that the source reference doesn't provide any examples. Will need to find them...
From @AhMohsen46
@ronaldtse related doc is having arabic equivalents, but it's not basically arabic, I -unforunately- don't think I can do this
however, if we had no other option I may do a little bit of exploration and transliterate the 22 letter language as per the doc, but I can't guarantee a 100% of success and test coverage