fix: correct Codex MCP TOML format, fix Windows HOME fallback (#18)#27
Conversation
Codex expects [mcp_servers.infigraph] as a sub-table, but install_toml_target was writing [mcp] with an inline table — Codex never saw the entry. Also escape backslashes in Windows paths so generated TOML actually parses. Separately, infigraph-mcp read HOME directly with no USERPROFILE fallback in 7 places (registry lookups, mcp.log path, instance lock, group reindex) — broken on Windows where HOME is typically unset. Now falls back to dirs_next::home_dir() like infigraph-core already does. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Tested PR #27 at I completed both automated and manual testing. The focused TOML install/uninstall tests passed, and after removing my previous manual registration and running the PR-built
The Codex MCP fix works correctly in my macOS environment. |
johnintuit
left a comment
There was a problem hiding this comment.
@murari316 can you pls approve
|
@murari316 can you pls approve? |
murari316
left a comment
There was a problem hiding this comment.
Reviewed diff in full — Codex TOML section fix and Windows HOME->dirs_next fallback across 7 sites, all consistent and covered by new tests (escaping, section preservation, actual TOML parse roundtrip). Approving.
Codex expects [mcp_servers.infigraph] as a sub-table, but install_toml_target was writing [mcp] with an inline table — Codex never saw the entry. Also escape backslashes in Windows paths so generated TOML actually parses.
Separately, infigraph-mcp read HOME directly with no USERPROFILE fallback in 7 places (registry lookups, mcp.log path, instance lock, group reindex) — broken on Windows where HOME is typically unset. Now falls back to dirs_next::home_dir() like infigraph-core already does.
Summary
Test plan
cargo test --allpassescargo clippy --all-targetspassesNotes