refactor: drop optional POSTHOG_IP_HASH_SALT#505
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ud99xX7wsfWTpsu8TQxAiZ
|
|
|
🚅 Deployed to the docs.page-pr-505 environment in docs.page
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Elliot Hesp · Slack thread
Before / After: IP anonymization previously used an HMAC when
POSTHOG_IP_HASH_SALTwas set, falling back to a plain SHA-256. It now always uses a plain SHA-256, and thePOSTHOG_IP_HASH_SALTenv var is gone. That's one less deploy variable — the only PostHog env var is nowPOSTHOG_KEY.How: Simplified
anonymizeIpinapp/src/lib/posthog.ts— removed thecreateHmacimport and the salt/HMAC branch.Note: A plain, unsalted SHA-256 of an IP is pseudonymous but technically reversible (the IPv4 space is small enough to brute-force). The privacy policy's "irreversibly hashed" wording (introduced in PR #500,
docs/legal/privacy.mdx) should be softened to "hashed" to stay accurate.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ud99xX7wsfWTpsu8TQxAiZ
Generated by Claude Code