chore: format generated firebase.json for readability#418
Open
amalej wants to merge 1 commit intoinvertase:mainfrom
Open
chore: format generated firebase.json for readability#418amalej wants to merge 1 commit intoinvertase:mainfrom
amalej wants to merge 1 commit intoinvertase:mainfrom
Conversation
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running
flutterfire configuregenerates afirebase.jsonlike{"firestore":{"database":"(default)","location":"nam5","rules":"firestore.rules","indexes":"firestore.indexes.json"},"flutter":{"platforms":{"dart":{"lib/firebase_options.dart":{"projectId":"PROJECT_ID","configurations":{"web":"APP_ID"}}}}}}Add formatting to the generated
firebase.jsonoutput when runningflutterfire configure.{ "firestore": { "database": "(default)", "location": "nam5", "rules": "firestore.rules", "indexes": "firestore.indexes.json" }, "flutter": { "platforms": { "dart": { "lib/firebase_options.dart": { "projectId": "PROJECT_ID", "configurations": { "web": "APP_ID" } } } } } }Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chorenote: it doesn't seem like
writeFirebaseJsonFileis used anywhere, but updating it anyway. in case we'd prefer this to be removed, just let me know