fix: adopt firebase-js-sdk 12.12.1 by mikehardy · Pull Request #9003 · invertase/react-native-firebase

mikehardy · 2026-05-01T01:27:57Z

Description

The title of the PR (adopt firebase-js-sdk 12.12.1) is the real point of the commit stream

while in there I adopted all other javascript deps updates that I could in the process

most importantly I moved us to typescript 6 after a quick test showed it to be - seemingly - trivial

I also caught a bug where yarn tests:macos:build could fail and wouldn't return an error exit code because the | xcbeautify part of the run script ate it. I used an explicit bash subshell and set -o pipefail to remedy

Related issues

Nothing logged, but the goal is to have all the upstream SDKs updated here in main, then I can pick them for a stable release that gets folks up to date SDKs while we queue breaking changes on main

Release Summary

all conventional commits with good messages

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
- Yes
My change supports the following platforms;
- Android
- iOS
- Other (macOS, web)
My change includes tests;
- e2e tests added or updated in packages/\*\*/e2e
- jest tests added or updated in packages/\*\*/__tests__
I have updated TypeScript types that are affected by my change.
This is a breaking change;
- Yes
- No

Test Plan

yarn test:full locally and CI

Think react-native-firebase is great? Please consider supporting the project with any of the below:

👉 Star this repo on GitHub ⭐️
👉 Follow React Native Firebase and Invertase on Twitter

gemini-code-assist · 2026-05-01T01:29:35Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a comprehensive dependency upgrade, primarily updating the firebase-js-sdk and migrating to TypeScript 6. These updates are crucial for maintaining compatibility, leveraging new features, and benefiting from performance and security enhancements in upstream libraries. Additionally, a specific issue affecting macOS test builds was addressed to improve the reliability of the CI/CD pipeline.

Highlights

Firebase SDK Update: The core firebase-js-sdk has been updated to version 12.12.1, ensuring the project uses the latest Firebase features and fixes.
TypeScript 6 Adoption: The project's TypeScript version has been upgraded to 6.0.3, allowing for the use of new language features and improved type checking.
Dependency Upgrades: Numerous other JavaScript dependencies across the project have been updated to their latest stable versions, improving overall stability and security.
macOS Test Build Fix: A bug in the yarn tests:macos:build script was resolved, ensuring that build failures are correctly reported by preventing xcbeautify from suppressing error exit codes.

Ignored Files

Ignored by pattern: .github/workflows/** (3)
- .github/workflows/scripts/functions/package.json
- .github/workflows/scripts/functions/tsconfig.json
- .github/workflows/scripts/functions/yarn.lock

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request performs a broad update of dependencies across the repository, notably upgrading TypeScript to 6.0.3 and updating various Firebase, Expo, and build-related packages. It also streamlines TypeScript configurations by removing redundant baseUrl properties and adding explicit type definitions to several packages. Actionable feedback was provided to address an invalid version range for @react-native-async-storage/async-storage in packages/app/package.json and tests/package.json, as the 2.x version series is currently non-existent.

mikehardy · 2026-05-01T13:13:11Z

emulator startup failures, strange - firebase-tools did upgrade across a semver major but it was working locally.
investigating

- node types need explicit inclusion in compiler options now - base path no longer needs to be specified if '.' - rootDir must be carefully specified though - need to disambiguate module name consts all trivial cleanups

this one needs frequent work, and yarn2 has built in patching this starts the conversion of our patches to built-in yarn2 style

…ments - removes deprecation warnings about node20 still being in use (updates) - incremental step to better software supply chain security (pinned SHAs)

…dening this version adopts a default posture of disallowing package scripts to run unless specifically configured to do so we've followed that default posture here, and just allowed the specific packages we expect to run scripts to do so in addition the 2 separate sub-workspaces are now pointing to a single yarn install in the root workspace, for easier upgrades in the future (or at least, it won't be possible to upgrade them separately as the binary will disappear and the sub-workspaces will error, highlighting the need to update their .yarnrc.yml yarnPath entry and make sure they work)

mikehardy added 2 commits April 30, 2026 18:33

test(macos): return build fail status despite xcbeautify pipe

4fa9be3

chore(test): update ios test pod lockfile

22aa58f

mikehardy requested a review from russellwheatley May 1, 2026 01:28

gemini-code-assist Bot reviewed May 1, 2026

View reviewed changes

Comment thread packages/app/package.json

Comment thread tests/package.json

mikehardy force-pushed the @mikehardy/dependency-updates branch from 2f60d3c to 276db3b Compare May 1, 2026 03:42

github-actions Bot added the Needs Attention label May 1, 2026

mikehardy added 8 commits May 1, 2026 13:22

build(deps): forward-port to typescript 6

a865078

- node types need explicit inclusion in compiler options now - base path no longer needs to be specified if '.' - rootDir must be carefully specified though - need to disambiguate module name consts all trivial cleanups

build(deps): adopt all patch/minor version upgrades

9af8caa

build(deps): adopt breaking change deps versions where possible

d7a8dd4

fix: adopt firebase-js-sdk 12.12.1

1211159

test: convert detox patch-package patch to yarn patch style

11fc3cb

this one needs frequent work, and yarn2 has built in patching this starts the conversion of our patches to built-in yarn2 style

test(deps): update all workflow actions, pin to SHA w/descriptive com…

4907a39

…ments - removes deprecation warnings about node20 still being in use (updates) - incremental step to better software supply chain security (pinned SHAs)

test: upload firebase emulator logs in CI for troubleshooting

29acb7a

mikehardy force-pushed the @mikehardy/dependency-updates branch from 0a3548f to 29acb7a Compare May 1, 2026 18:23

mikehardy added Workflow: Pending Merge Waiting on CI or similar and removed Needs Attention Workflow: Pending Merge Waiting on CI or similar labels May 1, 2026

mikehardy merged commit 9f0d6ed into main May 1, 2026
19 of 20 checks passed

mikehardy deleted the @mikehardy/dependency-updates branch May 1, 2026 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: adopt firebase-js-sdk 12.12.1#9003

fix: adopt firebase-js-sdk 12.12.1#9003
mikehardy merged 10 commits into
mainfrom
@mikehardy/dependency-updates

mikehardy commented May 1, 2026

Uh oh!

gemini-code-assist Bot commented May 1, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

mikehardy commented May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

mikehardy commented May 1, 2026

Description

Related issues

Release Summary

Checklist

Test Plan

Uh oh!

gemini-code-assist Bot commented May 1, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

mikehardy commented May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant