chore: delete old config setup for compare scripts and get types from root node_modules/#9011
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the type comparison infrastructure to eliminate the need for manual firebase-js-sdk type snapshots. By dynamically resolving types from the installed node_modules/firebase package, the process becomes more robust and easier to maintain. Additionally, the configuration files have been centralized into a dedicated directory, improving project structure and simplifying the registration of new packages. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the type comparison tool to dynamically resolve Firebase JS SDK types from the root node_modules instead of relying on manual snapshots, and moves package configurations to a dedicated configs/ directory. The reporting output is enhanced with a new package summary table. Feedback suggests adding a truthiness check for parsed JSON entries in the registry to prevent potential runtime crashes and improving terminal messages by replacing generic "" placeholders with actual package names for better clarity.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
mikehardy
left a comment
There was a problem hiding this comment.
Really nice evolution for this tool - not surprised to see the AI and Pipelines divergence as I knew the upstream API expanded but the scope of the Pipelines expansion is still ... impressive. Moving quickly upstream there
Description
Now produces a nice summary at the end for ease of reference:
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter