Skip to content

chore: delete old config setup for compare scripts and get types from root node_modules/#9011

Merged
russellwheatley merged 5 commits into
mainfrom
compare-script-update
May 8, 2026
Merged

chore: delete old config setup for compare scripts and get types from root node_modules/#9011
russellwheatley merged 5 commits into
mainfrom
compare-script-update

Conversation

@russellwheatley
Copy link
Copy Markdown
Member

@russellwheatley russellwheatley commented May 8, 2026

Description

  • Resolve Firebase JS SDK comparison types from the installed root firebase package instead of checked-in copied snapshots.
  • Flatten compare-types package configs into configs/.ts and update docs/imports accordingly.
  • Add missing documented differences surfaced by comparing against live SDK declarations.
  • Add a final per-package summary table to the compare-types output.

Now produces a nice summary at the end for ease of reference:

Screenshot 2026-05-08 at 14 39 00

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the type comparison infrastructure to eliminate the need for manual firebase-js-sdk type snapshots. By dynamically resolving types from the installed node_modules/firebase package, the process becomes more robust and easier to maintain. Additionally, the configuration files have been centralized into a dedicated directory, improving project structure and simplifying the registration of new packages.

Highlights

  • Dynamic Type Resolution: Removed manual firebase-js-sdk type snapshots in favor of dynamically resolving types from the installed node_modules/firebase package.
  • Centralized Configuration: Migrated all package-specific configuration files from individual package directories to a centralized configs/ directory.
  • Enhanced Reporting: Added a new package summary table to the CLI output to provide a clearer overview of type comparison results.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@russellwheatley russellwheatley requested a review from mikehardy May 8, 2026 13:14
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the type comparison tool to dynamically resolve Firebase JS SDK types from the root node_modules instead of relying on manual snapshots, and moves package configurations to a dedicated configs/ directory. The reporting output is enhanced with a new package summary table. Feedback suggests adding a truthiness check for parsed JSON entries in the registry to prevent potential runtime crashes and improving terminal messages by replacing generic "" placeholders with actual package names for better clarity.

Comment thread .github/scripts/compare-types/src/registry.ts Outdated
Comment thread .github/scripts/compare-types/src/report.ts Outdated
Comment thread .github/scripts/compare-types/src/report.ts Outdated
Comment thread .github/scripts/compare-types/src/report.ts Outdated
Comment thread .github/scripts/compare-types/src/report.ts Outdated
Comment thread .github/scripts/compare-types/src/report.ts Outdated
Comment thread .github/scripts/compare-types/src/report.ts Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@russellwheatley russellwheatley changed the title chore: delete old config setup for compare scripts chore: delete old config setup for compare scripts and get types from root node_modules/ May 8, 2026
Copy link
Copy Markdown
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice evolution for this tool - not surprised to see the AI and Pipelines divergence as I knew the upstream API expanded but the scope of the Pipelines expansion is still ... impressive. Moving quickly upstream there

@russellwheatley russellwheatley marked this pull request as ready for review May 8, 2026 13:55
@russellwheatley russellwheatley merged commit ef89d7b into main May 8, 2026
22 checks passed
@russellwheatley russellwheatley deleted the compare-script-update branch May 8, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants