fix: link to Firebase FCM API documentation#9015
Conversation
Updated the link to Firebase documentation for FCM API implementation.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request corrects a broken or outdated link within the messaging documentation. By updating the reference to the Firebase documentation, it ensures that developers are directed to the appropriate resource for configuring message payload options. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates a Firebase documentation link in the messaging usage guide. The reviewer suggests using a broader link to the 'Customize messages' page rather than the specific 'Set message type' page to better reflect the variety of options discussed in the documentation.
| is loaded and ready to run. | ||
|
|
||
| To learn more about how to send these options in your message payload, view the Firebase documentation for your [FCM API implementation](https://firebase.google.com/docs/cloud-messaging/concept-options). | ||
| To learn more about how to send these options in your message payload, view the Firebase documentation for your [FCM API implementation](https://firebase.google.com/docs/cloud-messaging/customize-messages/set-message-type). |
There was a problem hiding this comment.
The updated link points specifically to the "Set message type" page. However, the preceding paragraphs discuss multiple message options including priority and content-available. Linking to the parent "Customize messages" page would be more appropriate as it covers all these configuration options in one place.
To learn more about how to send these options in your message payload, view the Firebase documentation for your [FCM API implementation](https://firebase.google.com/docs/cloud-messaging/customize-messages).
Updated the link to Firebase documentation for FCM API implementation.
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter