feat(firestore): variable() and arrayFilter() API features for pipelines#9017
feat(firestore): variable() and arrayFilter() API features for pipelines#9017russellwheatley wants to merge 6 commits into
variable() and arrayFilter() API features for pipelines#9017Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the Firestore pipeline capabilities by adding support for variable expressions and array filtering. These additions allow developers to perform more advanced queries and data transformations directly within pipelines. The changes include updates to the core library, native bridge implementations for both Android and iOS, and updated type definitions to support the new API surface. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for variable expressions and the arrayFilter function within Firestore pipelines across Android, iOS, and Web platforms. The changes include updates to the serialization and parsing logic in native code, the addition of new TypeScript interfaces and helper functions, and comprehensive testing including unit, type, and E2E tests. A review comment suggests refining the return type of the variable function to VariableExpression to enhance type safety and maintain consistency with the Firebase JS SDK.
variable() and arrayFilter API features for pipelinesvariable() and arrayFilter() API features for pipelines
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter