fix(embed): scope CSS preflight and add navbar brand props#11
Merged
Conversation
Disable global preflight and inject an equivalent reset under #rosview-root so importing @ioai/rosview/style.css no longer resets host navbar/button styles.
Expose showNavbarBrand and navbarBrandLabel on RosViewer so hosts can hide or replace the default ROS View label, and document CSS scoping plus branding in the English and Chinese embedding guides.
…lotChart logic Introduce a new utility function to determine if the X axis should be pinned to the full log range during incremental updates. Update the usePlotChart implementation to utilize this function, ensuring the X scale remains consistent while data is loading. Additionally, refine the scoped preflight CSS for better integration with the host application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#rosview-root, so importing@ioai/rosview/style.cssno longer resets host navbar/button styles in Next.js and other embed scenarios.showNavbarBrandandnavbarBrandLabelonRosViewerso hosts can hide or replace the default left navbar "ROS View" label while keeping File/Layout menus.docs/EMBEDDING.mdanddocs/EMBEDDING.zh.md.Test plan
npm run build:libsucceeds; built CSS has no naked element preflight selectors@ioai/rosview/style.cssshowNavbarBrand={false}hides the left brand button; File/Layout menus still visiblenavbarBrandLabel="Custom Name"replaces default product name in navbar