Fix compute_timer_precision to not always take 1 second#307
Merged
ionelmc merged 1 commit intoionelmc:masterfrom Mar 26, 2026
Merged
Fix compute_timer_precision to not always take 1 second#307ionelmc merged 1 commit intoionelmc:masterfrom
ionelmc merged 1 commit intoionelmc:masterfrom
Conversation
Contributor
Author
|
This branch:
Helps a bit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was
viztraceringpytest-benchmark(because I had given up on fastidiously running tests locally because it was slow 😄) and noticedcompute_timer_precision()always took a suspicious exactly-one-second.Looks like the code had a little logic issue so it always took up to the timeout, even if there were enough data points to go on with.
This PR proposes to fix that logic bug (
andinstead ofor), and then increases the minimum number of data points to 100.This means that for each of the
pytestsubprocesses spawned by the test suite, there's about 1 second less of waiting...