Implement post-fix rescan and finding diffing for verify outcomes#29
Merged
ionfwsrijan merged 1 commit intoJun 4, 2026
Merged
Conversation
Contributor
Author
|
@ionfwsrijan, |
Owner
|
@sasidaran-99 LGTM merging it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #27
What this PR does
Implements post-fix rescanning and finding diffing for verify outcomes. The
/verifyendpoint now re-runs security scanners, compares the results against the baseline findings stored during the initial scan, calculates newly introduced findings, and updates the verification outcome accordingly.Type of change
ML tier (if applicable)
Changes
Backend
/verify.rule_id,file_path, andline_number.new_issues_introducedvalues.passedstatus to require both successful verification and zero newly introduced findings.Database / schema changes
Testing
How did you test this?
/scan.job_idwas generated./verifyusing the generatedjob_id.Checklist
console.erroror unhandled Python exceptions introducedrequirements.txt/package.jsonupdated if new dependencies added.pkl,.pt, etc.) are gitignored, not committedAnything reviewers should focus on
Please review the finding comparison logic used to identify newly introduced findings and the updated verification outcome calculation.