Skip to content

Remove NetworkType.CONNECTED constraint - allows offline background execution#159

Open
Random90 wants to merge 1 commit into
ionic-team:mainfrom
Random90:main
Open

Remove NetworkType.CONNECTED constraint - allows offline background execution#159
Random90 wants to merge 1 commit into
ionic-team:mainfrom
Random90:main

Conversation

@Random90

Copy link
Copy Markdown

Description

There is no need to blocking background runner from starting when there is no internet connection or when the app has no internet permission. There is tons of use cases for bg runner without the internet.
If there is no internet, the task invoked by the runner should handle it, not the runner.

This is potentially breaking change for low quality tasks.

Change Type

  • Fix
  • Feature
  • Refactor
  • Breaking Change
  • Documentation
  • Other (CI, chores, etc.)

Issue link

#158

Rationale / Problems Fixed

As in the description. My app is fully offline, so I removed the internet permission and background runner failed to run.

Tests or Reproductions

With any project using the background runner, either disable the internet or remove the internet permission and see if it still runs. Before the change, task was never invoked.

Platforms Affected

  • Android
  • iOS
  • Web

@changeset-bot

changeset-bot Bot commented Jul 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8122c98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant