Remove NetworkType.CONNECTED constraint - allows offline background execution#159
Open
Random90 wants to merge 1 commit into
Open
Remove NetworkType.CONNECTED constraint - allows offline background execution#159Random90 wants to merge 1 commit into
Random90 wants to merge 1 commit into
Conversation
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is no need to blocking background runner from starting when there is no internet connection or when the app has no internet permission. There is tons of use cases for bg runner without the internet.
If there is no internet, the task invoked by the runner should handle it, not the runner.
This is potentially breaking change for low quality tasks.
Change Type
Issue link
#158
Rationale / Problems Fixed
As in the description. My app is fully offline, so I removed the internet permission and background runner failed to run.
Tests or Reproductions
With any project using the background runner, either disable the internet or remove the internet permission and see if it still runs. Before the change, task was never invoked.
Platforms Affected