Conversation
jcesarmobile
left a comment
jcesarmobile
left a comment
There was a problem hiding this comment.
The typescript update causes
node_modules/@types/node/globals.d.ts:126:13 - error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; any(signals: AbortSignal[]): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }'.
|
Also, I think the PR should be agains next branch, not main |
jcesarmobile
left a comment
jcesarmobile
left a comment
There was a problem hiding this comment.
Some dependencies are getting updated with ~ and others with ^, in the migrator tool we make them all ^, so I think we should follow the same approach on our repositories.
example-app shouldn't be removed from the .prettierignore file, in create-capacitor-app package we add example-app in there to prevent changes on the example apps as some rules used with our linters might interfere in apps.
That means, the lint changes in example-app should also be reverted.
The prettier-plugin-java update requires this change Chace made but you missed
8558b26#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R40
5 participants
No description provided.