Skip to content

fix(local-notifications): honor autoCancel when a notification is tapped #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
begezavr2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(local-notifications): honor autoCancel when a notification is tapped #2568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...id/src/main/java/com/capacitorjs/plugins/localnotifications/LocalNotificationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ public JSObject handleNotificationActionPerformed(Intent data, NotificationStora
}
String menuAction = data.getStringExtra(LocalNotificationManager.ACTION_INTENT_KEY);

dismissVisibleNotification(notificationId);

dataJson.put("actionId", menuAction);
JSONObject request = null;
try {
Expand All @@ -93,6 +91,15 @@ public JSObject handleNotificationActionPerformed(Intent data, NotificationStora
request = new JSObject(notificationJsonString);
}
} catch (JSONException e) {}

// Only dismiss the tapped notification when autoCancel allows it; the
// builder already applies setAutoCancel(), but this explicit cancel used
// to run unconditionally, making `autoCancel: false` a no-op on tap.
boolean autoCancel = request == null || request.optBoolean("autoCancel", true);
if (autoCancel) {
dismissVisibleNotification(notificationId);
}

dataJson.put("notification", request);
return dataJson;
}
Expand Down