fix(SystemBars): make safe-area-inset-x available on API <= 34#8424
fix(SystemBars): make safe-area-inset-x available on API <= 34#8424theproducer wants to merge 3 commits intomainfrom
safe-area-inset-x available on API <= 34#8424Conversation
|
Hi, thanks for this PR. |
|
@luisbytes Do you have a test app that I can play around with and test some changes against? |
|
@theproducer |
|
@theproducer Upon reviewing, I noticed that the AdMob plugin adds padding based on the safe area, but only for Android 15+. This leaves me wondering how plugins that need to display something natively on screen should handle the safe area: based on the WebView version or the Android version? I'll also leave a Playground repository. I encountered more problems with the AdMob plugin on Android 15 and 16 with WebViews lower than 140 (it works fine in the latest WebView versions). The cause is this pull request: #8384. Downgrading to 8.2.0 fixes it. In conclusion, I believe this pull request can be merged, but guidelines or suggestions should be established for plugins that want to display native objects on WebViews. For now, I applied this patch to the patch/admob branch of the admob plugin, adding native padding based on the webview version, just like the systembars plugin currently does. I tested it on Android 11, 14, 15, and 16 with Webview <140 and >140, and it works fine. I'm considering whether to submit a PR to the AdMob plugin if these changes are mixed, applying padding based on the webview version. |


Description
This PR makes the custom injected
safe-area-inset-xCSS variables available for Android devices on API <= 34, to make dealing with UI safe area logic more consistent across Android versions.Change Type
Rationale / Problems Fixed
fixes: #8394
Tests or Reproductions
Screenshots / Media
Platforms Affected
Notes / Comments