chore: remove unused error codes from IONCAMRError#12
Conversation
Removes NO_IMAGE_SELECTED_ERROR, GET_IMAGE_ERROR, PERMISSION_DENIED_ERROR, UNABLE_TO_ACCESS_GALLERY_ERROR, FILE_NOT_FOUND_OR_INACCESSIBLE_ERROR, FAILED_TO_SAVE_FILE_ERROR, and RESOURCE_BUSY_ERROR as they are no longer used.
alexgerardojacinto
changed the title
alexgerardojacinto
requested review from
OS-pedrogustavobilro and
OS-ruimoreiramendes
|
|
||
| enum class IONCAMRError(val code: Int, val description: String) { | ||
| CAMERA_PERMISSION_DENIED_ERROR(3, "Couldn't access camera. Check your camera permissions and try again."), | ||
| NO_IMAGE_SELECTED_ERROR(5, "No image selected."), |
There was a problem hiding this comment.
Should we re-use 5 for something then? Don't see it being used elsewhere.
There was a problem hiding this comment.
Yes we should. I was still going to do that but wanted to go through the list of errors in Confluence first and only then start changing error codes
There was a problem hiding this comment.
Changed it now, it's being used for the GALLERY_PERMISSION_DENIED_ERROR now
| NO_CAMERA_AVAILABLE_ERROR(8, "No camera available."), | ||
| EDIT_IMAGE_ERROR (10, "Couldn't edit image."), | ||
| TAKE_PHOTO_ERROR(11, "Couldn't capture picture."), | ||
| GET_IMAGE_ERROR(12, "Couldn't get image from the gallery."), |
There was a problem hiding this comment.
This one's being used on iOS, so we can't re-use it for something else on Android right?
There was a problem hiding this comment.
maybe we can use it here instead of GENERIC_CHOOSE_MULTIMEDIA_ERROR
There was a problem hiding this comment.
I don't see anywhere to use it. @OS-ruimoreiramendes the line you shared can also be returned for videos, right?
There was a problem hiding this comment.
hum yeah, is for both images and videos, so doesn't make sense to use GET_IMAGE_ERROR since specifies images
There was a problem hiding this comment.
yeah so I don't see anywhere else we can use it - and that's fine
alexgerardojacinto
merged commit d7be685
into
feat/RMET-4099/android-implementation
3 participants
Summary
IONCAMRError:NO_IMAGE_SELECTED_ERROR,GET_IMAGE_ERROR,PERMISSION_DENIED_ERROR,UNABLE_TO_ACCESS_GALLERY_ERROR,FILE_NOT_FOUND_OR_INACCESSIBLE_ERROR,FAILED_TO_SAVE_FILE_ERROR, andRESOURCE_BUSY_ERROR