fix: properly await when allowEdit=true#1
Merged
andredestro merged 7 commits intomainfrom Mar 27, 2026
Merged
Conversation
OS-pedrogustavobilro
changed the title
allowEdit=true
alexgerardojacinto
approved these changes
Mar 27, 2026
…-picture-allow-edit-move-task-upwards
andredestro
force-pushed
the
fix/take-picture-allow-edit-move-task-upwards
branch
from
cbd0856 to
f4ee061
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting an issue on iOS when using
TakePhotowithallowEdit=true, where theMediaResultwasn't being returned correctly.The root cause was on 08b7436 for
Sources/IONCameraLib/IONCAMRFlowBehaviour.swift, that was creating aTaskto asynchronously process image to edit, which was causing thedeferto be called, clearing theTakePhotooptions, and therefore losing the state needed to returnMediaResult.I change the code to not launch a
Taskfrom those methods, mark them as async-await, and move the asynchronousTaskcreation further up the call hierarchy.Had to update
Sources/IONCameraLib/IONCAMRCoordinator.swiftto switch to main thread when dismissing, because otherwise due to the other changes it would crash stating thatdismisswas being called outside main thread.