Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
The Angular documentation presents the Modules approach and
IonicModuleas a fully supported option with no indication that it is being phased out. The Build Options guide, the per config guides, and the Platform guide all showIonicModule.forRoot()examples, and the Ionic 9 upgrade guide does not mention the deprecation.What is the new behavior?
docs/angular/build-options.md: notes that the Modules approach andIonicModuleare deprecated as of Ionic 9, adds a Deprecation Notice admonition to the Modules section, and adds a code splitting note explaining the single entry point limitation of the standalone build.docs/updating/9-0.md: adds anIonicModuleDeprecation entry that points to the migration guide.docs/developing/config/*anddocs/angular/platform.md: add a deprecation comment above theIonicModuleexamples that points developers toprovideIonicAngular(). The Platform guide example is converted into Angular and Angular (Standalone) tabs so the standalone equivalent is shown alongside the Modules version.Does this introduce a breaking change?
Other information
Previews:
docs/angular/build-optionsdocs/angular/platformdocs/updating/9-0docs/developing/config/globaldocs/developing/config/per-componentdocs/developing/config/per-platformdocs/developing/config/per-platform-fallbackdocs/developing/config/per-platform-overrides