feat(icon): add font icon support to ion-icon#31284
Open
brandyscarney wants to merge 6 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
changed the title
brandyscarney
commented
Jul 23, 2026
| .input-clear-icon ion-icon { | ||
| width: 100%; | ||
| height: 100%; | ||
| font-size: globals.$ion-font-size-400; |
Member
Author
There was a problem hiding this comment.
This is set to 400 because it renders at 16px with width/height set to 100%
brandyscarney
commented
Jul 23, 2026
| } | ||
|
|
||
| /* Large */ | ||
| :host(.searchbar-size-large) .searchbar-search-icon, |
Member
Author
There was a problem hiding this comment.
I combined these rules because the .searchbar-search-icon needs font-size too.
brandyscarney
commented
Jul 23, 2026
|
|
||
| ::slotted(*) ion-icon[slot="icon-only"] { | ||
| font-size: globals.$ion-font-size-600; | ||
| font-size: globals.$ion-font-size-500; |
Member
Author
There was a problem hiding this comment.
This was not using the correct value before. The change to other components to use font-size with ion-icon exposed this as the wrong size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Ionicons added support for font icons in
ion-icon, but Ionic Framework does not support it.What is the new behavior?
ion-iconusingwidth/heightto usefont-sizeso it will style them for both SVGs and font icons.Does this introduce a breaking change?
Other information
Preview: icon: font
Dev build:
8.8.16-dev.11784841344.1aa1a41c