Skip to content
This repository was archived by the owner on May 27, 2021. It is now read-only.

Throw error if app id is not given#29

Open
ajoslin wants to merge 1 commit intoionic-team:masterfrom
ajoslin:app_id_throw
Open

Throw error if app id is not given#29
ajoslin wants to merge 1 commit intoionic-team:masterfrom
ajoslin:app_id_throw

Conversation

@ajoslin
Copy link

@ajoslin ajoslin commented Jul 28, 2015

I had this code:

function IonicConfig ($ionicAppProvider) {
  $ionicAppProvider.identify({
    app_id: env.ionicAppId,
    api_key: env.ionicApiKey
  })
}

My env didn't have ionicAppId and ionicApiKey, even though I thought it did. A stupid mistake.

But the undefined appId and apiKey were causing $ionicDeploy.checkUpdate() to crash my app.

Now the javascript will throw an error if app_id is undefined.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments